Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding security policy #11

Merged
merged 5 commits into from
May 31, 2024
Merged

adding security policy #11

merged 5 commits into from
May 31, 2024

Conversation

ahmedsobeh
Copy link
Collaborator

@ahmedsobeh ahmedsobeh commented May 29, 2024 •
edited by aiven-sal
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR adds a security policy to the repo. One that is consistent with that of Valkey itself

This PR resolves issue #10

@ahmedsobeh
adding security policy
68c5863 
Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh ahmedsobeh force-pushed the add-security-policy branch 2 times, most recently from e122836 to 68c5863 Compare May 29, 2024 10:36
@ahmedsobeh ahmedsobeh linked an issue May 29, 2024 that may be closed by this pull request
Add a security policy #10
Closed
aiven-sal
aiven-sal reviewed May 29, 2024
View reviewed changes
SECURITY.md Show resolved Hide resolved
@ahmedsobeh
updating contributing.md
53303ff 
Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh ahmedsobeh force-pushed the add-security-policy branch from 543c873 to 53303ff Compare May 30, 2024 22:21
@ahmedsobeh
updating contributing.md
ab23003 
Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh ahmedsobeh force-pushed the add-security-policy branch from 46d549f to ab23003 Compare May 30, 2024 22:29
ahmedsobeh added 2 commits May 30, 2024 23:38
@ahmedsobeh
updating contributing.md
a74ab95 
Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh
updating contributing.md
78e1da0 
Signed-off-by: ahmedsobeh <[email protected]>
@ahmedsobeh ahmedsobeh requested a review from aiven-sal May 30, 2024 22:41
aiven-sal
aiven-sal approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aiven-sal aiven-sal merged commit dcad4a3 into main May 31, 2024
48 checks passed
@aiven-sal aiven-sal deleted the add-security-policy branch May 31, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiven-sal aiven-sal aiven-sal approved these changes

@mkmkme mkmkme Awaiting requested review from mkmkme mkmkme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a security policy
2 participants
@ahmedsobeh @aiven-sal