Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix verify params in getex() #145

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

spyinx
Copy link
Contributor

@spyinx spyinx commented Dec 6, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

close: #142

Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (8d9470d) to head (3b1f34c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   76.19%   76.20%           
=======================================
  Files         130      130           
  Lines       33907    33909    +2     
=======================================
+ Hits        25837    25841    +4     
+ Misses       8070     8068    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I suppose we could have more tests to cover other combinations of arguments, but this should be fine for now.

@aiven-sal aiven-sal enabled auto-merge December 6, 2024 16:40
@aiven-sal aiven-sal merged commit e74cefa into valkey-io:main Dec 6, 2024
93 checks passed
aiven-sal added a commit that referenced this pull request Dec 10, 2024
following up from #145

Signed-off-by: Salvatore Mesoraca <[email protected]>
@aiven-sal aiven-sal mentioned this pull request Dec 10, 2024
@spyinx spyinx deleted the fix-verify-in-getex branch December 11, 2024 13:12
mkmkme pushed a commit that referenced this pull request Dec 12, 2024
following up from #145

Signed-off-by: Salvatore Mesoraca <[email protected]>
@mkmkme mkmkme added the maintenance dependabot PR's label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance dependabot PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getex() method has a error when verify parameters
4 participants