Revert #8 and replace "redis" and "old valkey" with "server" #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ebbc1d4. It also changes the mentions of "valkey 6.2" and "Redis 6.2" to "server 6.2" Signed-off-by: Mikhail Koviazin <[email protected]>
This reverts commit d4074a9. Signed-off-by: Mikhail Koviazin <[email protected]>
This reverts commit 506b789. Also mentions of "Valkey < 6.0.0" are fixed. Signed-off-by: Mikhail Koviazin <[email protected]>
This reverts commit a0e20ea. Additionally, it replaces "Redis" with "Server" in comments. Signed-off-by: Mikhail Koviazin <[email protected]>
This commit reverts b0fa7da and c175433 and effectively returns the tests for the older server versions. Signed-off-by: Mikhail Koviazin <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
aiven-sal
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR reverts #8 with some additional fixes being mostly replacing of "Redis" or "Valkey" with "Server"