Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some typing commits #163

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Dec 19, 2024

Issue #162 revealed that the issues with typing in valkey-py are quite a bit deeper and require some rework of internal classes. The changes introduced in those commits turned out to not fix anything.

At this point we need to publish the new beta because of accumulated fixes since 6.1.0b1. The typing system fixes will be introduced later.

Closes #162

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

This reverts commit c006c85.

Signed-off-by: Mikhail Koviazin <[email protected]>
This reverts commit 1fc6f9b.

Signed-off-by: Mikhail Koviazin <[email protected]>
This reverts commit 9adb262.

Signed-off-by: Mikhail Koviazin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.23%. Comparing base (ce23ae4) to head (837cc91).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   76.23%   76.23%   -0.01%     
==========================================
  Files         130      130              
  Lines       33947    33947              
==========================================
- Hits        25879    25878       -1     
- Misses       8068     8069       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme mkmkme enabled auto-merge December 19, 2024 11:04
@mkmkme mkmkme merged commit 326e9c5 into valkey-io:main Dec 19, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new type hints i wrote seem to be wrong
3 participants