Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'View Test Results' step in CI #57

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Remove 'View Test Results' step in CI #57

merged 1 commit into from
Jul 17, 2024

Conversation

ahmedsobeh
Copy link
Collaborator

@ahmedsobeh ahmedsobeh commented Jul 15, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR fixes 'View Test Results' step in CI by removing the broken step.

Closes #43

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (6d69781) to head (458772c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   75.01%   75.01%           
=======================================
  Files         132      132           
  Lines       34367    34367           
=======================================
  Hits        25782    25782           
  Misses       8585     8585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmedsobeh ahmedsobeh closed this Jul 15, 2024
@ahmedsobeh ahmedsobeh reopened this Jul 16, 2024
@ahmedsobeh ahmedsobeh marked this pull request as draft July 16, 2024 07:36
@ahmedsobeh ahmedsobeh marked this pull request as ready for review July 16, 2024 07:57
@ahmedsobeh ahmedsobeh linked an issue Jul 16, 2024 that may be closed by this pull request
@ahmedsobeh ahmedsobeh changed the title Fixed 'View Test Results' step in CI Remove 'View Test Results' step in CI Jul 16, 2024
@mkmkme
Copy link
Collaborator

mkmkme commented Jul 17, 2024

Are we positive there's no way to fix it or the fix is not worth the hassle?

@mkmkme
Copy link
Collaborator

mkmkme commented Jul 17, 2024

Ah sorry, just noticed the issue description

@aiven-sal aiven-sal enabled auto-merge July 17, 2024 15:56
Signed-off-by: ahmedsobeh <[email protected]>
@aiven-sal aiven-sal merged commit 2b86482 into main Jul 17, 2024
67 checks passed
@aiven-sal aiven-sal deleted the issue-43 branch July 17, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'View Test Results' step broken
4 participants