Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds isclose checks to flaky geotests #61

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kjaymiller
Copy link
Contributor

@kjaymiller kjaymiller commented Jul 31, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • [NA] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [NA] Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

  • add geochecks to conftest
  • uses isclose to check float values
  • renamed check to assert_geo_is_close
  • update_assert_is_geo_tests
  • format with black

resolves #39

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.06%. Comparing base (67eb77c) to head (3b2c6b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   75.02%   75.06%   +0.03%     
==========================================
  Files         132      132              
  Lines       34341    34378      +37     
==========================================
+ Hits        25766    25805      +39     
+ Misses       8575     8573       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aiven-sal
Copy link
Member

Hi Jay! Thanks for the PR.
I don't know if you noticed, but there are some issues with this PR:
https://github.com/valkey-io/valkey-py/actions/runs/10186469705/job/28210444146?pr=61#step:4:125
You should also re-base it to pick up the latest changes.

@kjaymiller kjaymiller force-pushed the jm-geo-flaky-tests branch 2 times, most recently from 3803b5f to a358a7e Compare August 5, 2024 21:10
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for fixing the linters.
Could you squash/fixup all of you commits in the first one?

Otherwise the PR looks great!

tests/conftest.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_commands.py Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Show resolved Hide resolved
tests/test_commands.py Show resolved Hide resolved
tests/test_commands.py Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
tests/test_commands.py Outdated Show resolved Hide resolved
- add geochecks to conftest
- uses isclose to check float values
- renamed check to assert_geo_is_close
- update_assert_is_geo_tests
- format with black
- updates from pr

Signed-off-by: Jay Miller <[email protected]>
@aiven-sal aiven-sal force-pushed the jm-geo-flaky-tests branch from a402886 to 3b2c6b3 Compare August 7, 2024 08:21
@aiven-sal aiven-sal self-requested a review August 7, 2024 08:21
@aiven-sal aiven-sal enabled auto-merge August 7, 2024 08:22
Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aiven-sal
Copy link
Member

aiven-sal commented Aug 7, 2024

@mkmkme @ahmedsobeh my approval for this PR does not work, because I touched it. We need someone else's review.

@aiven-sal aiven-sal merged commit 92e3d34 into valkey-io:main Aug 7, 2024
75 checks passed
@kjaymiller kjaymiller deleted the jm-geo-flaky-tests branch August 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_geo*
4 participants