Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify RESP3 and other tests workflows #69

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Unify RESP3 and other tests workflows #69

merged 1 commit into from
Aug 5, 2024

Conversation

ahmedsobeh
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR removes RESP3 tests flow and combines it with run-tests. This would resolbe #46

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.02%. Comparing base (28ad27b) to head (e5d43ee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files         132      132           
  Lines       34341    34341           
=======================================
  Hits        25766    25766           
  Misses       8575     8575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmedsobeh ahmedsobeh force-pushed the issue-46 branch 3 times, most recently from 6bd50ea to 72d1de9 Compare August 5, 2024 11:43
@ahmedsobeh ahmedsobeh force-pushed the issue-46 branch 5 times, most recently from f63faee to c179f54 Compare August 5, 2024 12:11
mkmkme
mkmkme previously approved these changes Aug 5, 2024
Copy link
Collaborator

@mkmkme mkmkme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's see what tests are saying.

Also it seems that semi-linear history check is failing already now. You might have to rebase it on the top of main

@ahmedsobeh ahmedsobeh enabled auto-merge August 5, 2024 12:30
@ahmedsobeh ahmedsobeh merged commit 67eb77c into main Aug 5, 2024
79 of 80 checks passed
@ahmedsobeh ahmedsobeh deleted the issue-46 branch August 5, 2024 15:43
@ahmedsobeh ahmedsobeh linked an issue Aug 5, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify RESP3 and other tests workflows
3 participants