-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify RESP3 and other tests workflows #69
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 132 132
Lines 34341 34341
=======================================
Hits 25766 25766
Misses 8575 8575 ☔ View full report in Codecov by Sentry. |
6bd50ea
to
72d1de9
Compare
f63faee
to
c179f54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's see what tests are saying.
Also it seems that semi-linear history check is failing already now. You might have to rebase it on the top of main
Signed-off-by: ahmedsobeh <[email protected]>
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR removes RESP3 tests flow and combines it with run-tests. This would resolbe #46