Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add history rewrite utility methods #2

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

lwhiteley
Copy link
Collaborator

@lwhiteley lwhiteley commented Jan 7, 2024

Summary

  • Add history rewrite utility methods.
    • replace: used to replace a snapshot at a specified history index.
    • remove: used to remove a specified history index.
  • Add getNode utility method
  • add api docs generation. see here

drawing ideas from:

The remove function is used to remove a specified history index
@lwhiteley lwhiteley requested a review from dai-shi January 7, 2024 16:24
the replace method is a function to replace a snapshot at a specified history index
@lwhiteley lwhiteley force-pushed the history-remove-method branch 10 times, most recently from b355540 to 3130a40 Compare January 7, 2024 18:08
@lwhiteley lwhiteley force-pushed the history-remove-method branch from 3130a40 to 0b01e0d Compare January 7, 2024 18:22
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewed packages/history-utility/src/history-utility.ts, and it looks good to me.

@lwhiteley lwhiteley merged commit 25c3b7c into main Jan 8, 2024
1 check passed
@lwhiteley lwhiteley deleted the history-remove-method branch January 8, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants