Convert several perl scripts to python #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments and python code were originally generated by AI based on the original asy-list.pl code; however, both were subsequently checked and modified by a human to improve both Python coding style and accuracy to the original script. The change was tested by comparing the output of `make asy-keywords.el` before and after the change. The resulting files are identical except for the comment naming the generating script, which was originally asy-list.pl but is now asy-list.py. Thus, the two output files differ by a single character.
Tested: I used a logging statement in the original `findsym.pl` to check that all of the files written by `findsym.pl` followed the pattern `*symbols.h`. I then checked that after the change, the resulting files differed from the originals by a single character (since the comment now cites `findsym.py` rather than `findsym.pl` as the source). The sole exception was `opsymbols.h`, which had no changes at all since it is generated by a different script.
|
Can you ensure the CI passes before merging this in? Also, could you check that the python scriptd and the old perl files produce the same output? Another thing - the shebang lines should be "python3", not "python" |
|
Here's a list of all the diffs of potentially generated files, comparing master versus the current branch. I should note that in addition to the |
|
Also, just wondering, but is there a reason to use ascii encoding instead of UTF8? At least from my experience, I always use UTF-8 unless if there's a reason to use ASCII |
|
I was mainly concerned with fixing the lint errors. My reasoning, for the 30 seconds or so I spent thinking about this, was that if we have non-ascii characters in our C++ code (which is what these scripts are reading and writing, with the exception of Note that for scripts that read and write tex code or asy code (which can include tex code), I agree that utf8 is almost certainly preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert several perl scripts to python.
Python is now an installation dependency in any case, and the current asy developers are generally more familiar with python than with perl. Thus, converting the perl code to python should make it easier to maintain and improve these files.
Because I have noticed improvements being made to the perl scripts, I want to go ahead and get these merged even though I am still working on the most complex perl script,
runtime.pl.The translations are based on AI-provided translations but thoroughly checked by me (with numerous modifications in the process). They could of course still contain bugs, but I am confident they are not worse than what I would produce if I tried to do this without the aid of AI.
For testing, I added a log statement to the original perl script to figure out exactly how it was being used during
make, saved the results, and compared them to the results of the python generation. In all cases, the generated files differed by exactly one character, which was the name of the generating file (something.pl changed to something.py) in the comment block.Note: I have only tested the changes using the make utility. I do not know how to compile with cmake, although I have made an effort to change the cmake files as well.
Testing complication: At least on my machine, if I run a python file using perl, and it sees the python shebang line, it will call the python interpreter rather than interpreting the file as if it were perl. This could make it easy to miss if we're accidentally running python files with perl.