-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Initial support for React fiber. #2659
Conversation
Cool! |
Any chance this can be released on its own tag? For now I've forked your branch and published it here to allow using React Fiber on a Next.js app I'm working on that uses the new |
@stipsan that's something we can do just after we release 3.0. |
Alright. For my use case though it's a good tradeoff as I want to use in-memory cache for base64 encoded avatar uris (SVGs that are rendered in an I don't think it makes sense to use node-stream in use cases where you're not pushing a lot of data to the client. Which is most use cases, right? |
That's what we think right now. Streams doesn't add much in performance wise for Next.js. |
@stipsan @arunoda You are talking about streaming VS full-render performance from the unit of work perspective, but if you consider the performance from the user perspective you will notice that streaming can outperform full-render significantly due to the lower time to first byte (TTFB): https://www.youtube.com/watch?v=UhdGiVy3_Nk |
@frol thanks for sharing that video. It appears streams is the next performance frontier 😄 |
@arunoda @timneutkens |
Fiber is now in RC and I'm having to maintain two branches (one with next and react 15, one with next disabled and react 16). Would be great to get a timeline in this, and I'd be happy to help in any way I can! |
@arunoda react 16 is released, do you plan to merge? |
Continuing this work here: #2996 |
Tracking it here #2996 |
Fixes #1098
We are not going to merge this soon unless React 16 ships before 3.0 release.
Otherwise, we need to look at a way to detect React 16 and support React patching if that's React 15.