Fix subscription button text for different billing intervals #359
+2,737
−2,111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skeleton1231 is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
- Added `getUserSubscriptions` method in `supabase/queries` to fetch user subscriptions, ordered by creation time in descending order. - Updated `Pricing` component to handle user subscriptions: - Show "Manage" button for subscribed products and redirect to account management page. - Show "Subscribe" button for unsubscribed products. - Modified `PricingPage` to fetch user and their subscriptions, and pass them to the `Pricing` component. - Adjusted `Account` page to display the user's latest subscription and personal information.
XiChenn
reviewed
Aug 16, 2024
| const { data: subscriptions, error } = await supabase | ||
| .from('subscriptions') | ||
| .select('*, prices(*, products(*))') | ||
| .eq('user_id', user.id) |
There was a problem hiding this comment.
This is not necessary because subscriptions table in Supabase has enabled Row-Level Security (RLS) policies, meaning that, users can only access their own data.
| @@ -37,3 +43,24 @@ export const getUserDetails = cache(async (supabase: SupabaseClient) => { | |||
| .single(); | |||
| return userDetails; | |||
| }); | |||
|
|
|||
| export const getUserSubscriptions = cache(async (supabase: SupabaseClient, user: User | null) => { | |||
There was a problem hiding this comment.
This function doesn't seem necessary. When there are multiple subscriptions, the UI should generate an error to let the user know, because multiple subscriptions don't make sense to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix subscription button text and enhance subscription handling
Problem:
getSubscriptionfunction retrieves data without filtering by the user.Solution:
getUserSubscriptionsmethod insupabase/queriesto fetch user subscriptions, ordered by creation time in descending order.Pricingcomponent to handle user subscriptions:PricingPageto fetch user and their subscriptions, and pass them to thePricingcomponent.Accountpage to display the user's latest subscription and personal information.These changes improve the overall user experience by accurately reflecting the user's subscription status and providing appropriate actions based on their subscriptions.
If I have misunderstood any aspects of the problem or solution, please forgive my oversight. I look forward to your feedback and hope these changes align with the project's goals. Thank you for your understanding and support.