Update FlatBuffers to 24.3.6-1 (fix cannot set temporal layer 0) #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Due to an issue in Flatbuffers (google/flatbuffers#8245) when we call `consumer.setPreferredLayers()` with `temporalLayer: 0`, we are NOT passing `temporalLayer` to the worker so it selects the highest available temporal layer instead. - This PR tests that use case in both Node and Rust, and tests should fail until the Flatbuffers issue is resolved. - BTW the Flatbuffers issue was already fixed long ago (google/flatbuffers#8245) but well, maintainers have not released a new version since May 2023 because whatever inexplicable reason.
ibc
changed the title
jmillan
approved these changes
Feb 29, 2024
…er the flatbuffers bug
|
FlatBuffers 24.3.6 (with the fix) has been released. The NPM version is already available. Ongoing work in Meson WrapDB to update FlatBuffers there: mesonbuild/wrapdb#1441 |
- Due to an issue in Flatbuffers (google/flatbuffers#8245) when we call `consumer.setPreferredLayers()` with `temporalLayer: 0`, we are NOT passing `temporalLayer` to the worker so it selects the highest available temporal layer instead. - This PR tests that use case in both Node and Rust, and tests should fail until the Flatbuffers issue is resolved. - BTW the Flatbuffers issue was already fixed long ago (google/flatbuffers#8245) but well, maintainers have not released a new version since May 2023 because whatever inexplicable reason.
…er the flatbuffers bug
…a/mediasoup into test-preferred-temporal-layer-0
ibc
changed the title
jmillan
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consumer.setPreferredLayers()withtemporalLayer: 0(ortransport.consume()withtemporalLayer: 0inpreferredLayers), we are NOT passingtemporalLayerto the worker so it selects the highest available temporal layer instead.