Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimulcastConsumer fails to switch spatial layers #993

Closed
wants to merge 3 commits into from
Closed

Fix SimulcastConsumer fails to switch spatial layers #993

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75c3df8
Fix SimulcastConsumer fails to switch spatial layers (#990)
satoren Jan 28, 2023
530e886
fix lint error
satoren Jan 30, 2023
a89308d
Update worker/src/RTC/SimulcastConsumer.cpp
ibc Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions worker/src/RTC/SimulcastConsumer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,12 +685,13 @@ namespace RTC

// Check whether this is the packet we are waiting for in order to update
// the current spatial layer.
if (this->currentSpatialLayer != this->targetSpatialLayer && spatialLayer == this->targetSpatialLayer)
// clang-format off
if (
this->currentSpatialLayer != this->targetSpatialLayer &&
spatialLayer == this->targetSpatialLayer &&
packet->IsKeyFrame())
// clang-format on
ibc marked this conversation as resolved.
Show resolved Hide resolved
{
// Ignore if not a key frame.
if (!packet->IsKeyFrame())
return;

shouldSwitchCurrentSpatialLayer = true;

// Need to resync the stream.
Expand Down