Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme edits rjs #4

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Readme edits rjs #4

merged 9 commits into from
Dec 19, 2023

Conversation

rs-vertica
Copy link
Contributor

Updated README:

  • Intro
  • Install
  • Sample manifests with dropdowns
  • Usage
    • deploy Kafka and vertica, create tables, create Kafka topic, configure scheduler
  • Launch scheduler
  • Test implementation

spilchen
spilchen reviewed Dec 16, 2023
View reviewed changes
Copy link
Contributor

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more context here. Some suggestion on the samples used.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
spilchen
spilchen reviewed Dec 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
rs-vertica and others added 2 commits December 19, 2023 15:28
@rs-vertica @spilchen
Update README.md
2dd9b21 
Co-authored-by: spilchen <[email protected]>
@rs-vertica
Update README.md
72a7380 
PR review
@rs-vertica
Copy link
Contributor Author

@spilchen Addressed and resolved all PR comments.

spilchen
spilchen reviewed Dec 19, 2023
View reviewed changes
README.md Outdated
path: s3://<path>/<to>/<s3-bucket>
image: vertica/vertica-k8s:12.0.3-0
initPolicy: Create
passwordSecret: passwd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the setting of this secret since we don't provide the Secret?

README.md Outdated
username: dbadmin
dbport: '5433'
enable-ssl: 'false'
password: Vertica!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the password here too.

spilchen
spilchen approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these.

@spilchen spilchen merged commit 9aaea4a into vertica:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spilchen spilchen spilchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rs-vertica @spilchen