-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vertex delete with edge #103
Add vertex delete with edge #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!🫡
@Nicole00 how is everything going? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, excellent job!
@Nicole00 could you publish new version of that library? Thanks in advance |
@Nicole00 could we create a minor version release? |
Yeah, we can publish a minor version. |
@nick13145 @StrangerOfDawah @wey-gu version 3.8.1 already released to https://repo1.maven.org/maven2/com/vesoft/nebula-flink-connector/ |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description
This patch adds support for deleting vertices along with their edges in the Nebula connector. A new feature flag,
isDeleteExecutedWithEdges
, is introduced to control this behavior. Additionally, tests are added to verify the new functionality while ensuring existing functionality remains unaffected.How do you solve it?
NebulaVertices Class:
isDeleteExecutedWithEdges
.getDeleteStatement
method to use the appropriate delete template based on theisDeleteExecutedWithEdges
flag.VertexExecutionOptions Class:
isDeleteExecutedWithEdges
field.isDeleteExecutedWithEdges
.NebulaVertexBatchExecutor Class:
isDeleteExecutedWithEdges
flag fromVertexExecutionOptions
toNebulaVertices
.NebulaConstant Class:
DELETE_VERTEX_TEMPLATE_WITH_EDGE
.NebulaVerticesTest Class:
testGetDeleteStatementWithEdges
andtestGetDeleteStatementWithPolicyAndEdges
to validate the new delete behavior.Special notes for your reviewer
isDeleteExecutedWithEdges
flag, ensuring that existing code paths remain unchanged unless explicitly modified to use the new feature.