Skip to content

Commit

Permalink
Merge pull request #4477 from vgteam/remove-unnecessary-chromosome-er…
Browse files Browse the repository at this point in the history
…rors

Allow non-exons to have bad chromosomes
  • Loading branch information
adamnovak authored Dec 16, 2024
2 parents a0d588d + 98a06eb commit 230872c
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions src/transcriptome.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,15 @@ int32_t Transcriptome::parse_transcripts(vector<Transcript> * transcripts, uint3

auto chrom_lengths_it = chrom_lengths.find(chrom);

transcript_line_ss.ignore(numeric_limits<streamsize>::max(), '\t');
assert(getline(transcript_line_ss, feature, '\t'));

// Select only relevant feature types.
if (feature != feature_type && !feature_type.empty()) {

continue;
}

if (chrom_lengths_it == chrom_lengths.end()) {

if (error_on_missing_path) {
Expand All @@ -618,15 +627,6 @@ int32_t Transcriptome::parse_transcripts(vector<Transcript> * transcripts, uint3
}
}

transcript_line_ss.ignore(numeric_limits<streamsize>::max(), '\t');
assert(getline(transcript_line_ss, feature, '\t'));

// Select only relevant feature types.
if (feature != feature_type && !feature_type.empty()) {

continue;
}

// Parse start and end exon position and convert to 0-base.
assert(getline(transcript_line_ss, pos, '\t'));
int32_t spos = stoi(pos) - 1;
Expand Down

2 comments on commit 230872c

@adamnovak
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for branch v1.62.0. View the full report here.

16 tests passed, 0 tests failed and 0 tests skipped in 17519 seconds

@adamnovak
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for merge to master. View the full report here.

16 tests passed, 0 tests failed and 0 tests skipped in 17425 seconds

Please sign in to comment.