Refactor go parsing code #2946
Draft
Refactor go parsing code #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
npentrel
force-pushed
the
refactor-automation-code
branch
from
e533b1e to
3afee41
Compare
|
Overall readability score: 53.08 (🟢 +0)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
sguequierre
reviewed
May 23, 2024
docs/build/configure/webhooks.md
Outdated
| @@ -3,7 +3,7 @@ title: "Configure a Webhook" | |||
| linkTitle: "Webhooks" | |||
| weight: 50 | |||
| type: "docs" | |||
| description: "Configure a webhook to trigger actions when certain types of data are sent from your machine to the cloud, or when the internet connectivity of your machine changes." | |||
| description: "Configure a webhook to trigger actions when data is sent from your machine to the cloud, or when your machine's internet connectivity changes." | |||
sguequierre
reviewed
May 23, 2024
docs/data/trigger-sync.md
Outdated
| @@ -218,26 +218,24 @@ On your machine's **CONFIGURE** tab, switch to **JSON** mode and add a `selectiv | |||
| "type": "data_manager" | |||
| } | |||
| ], | |||
| "agent_config": { | |||
There was a problem hiding this comment.
Same here: not sure if this was intentional or old version of file
npentrel
force-pushed
the
refactor-automation-code
branch
4 times, most recently
from
b63bdca to
59fa9b5
Compare
npentrel
force-pushed
the
refactor-automation-code
branch
from
59fa9b5 to
c3b1642
Compare
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2946 |
|
@andf-viam also requesting your review here before I merge |
|
@npentrel I was hoping to hold off on refactors until the remainder of the enhancement work. Example: I am updating this same code right now. Would you mind if you held off on this until I can do all SDK languages in same fashion? I appreciate you showing me how you'd do it: I can take that and do all -- but next week please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and what is does. Please also include relevant motivation and context.