APP-6820: Adding the Enable Billing Service Action #4630
+94
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
benjirewis
approved these changes
Dec 20, 2024
jr22
reviewed
Dec 20, 2024
| @@ -989,6 +989,19 @@ func TestAppClient(t *testing.T) { | |||
| test.That(t, err, test.ShouldBeNil) | |||
| }) | |||
|
|
|||
| t.Run("EnableBillingSevice", func(t *testing.T) { | |||
There was a problem hiding this comment.
do we need code in app_client? whats this testing then?
There was a problem hiding this comment.
// EnableBillingService enables a billing service to an address in an organization.
func (c *AppClient) EnableBillingService(ctx context.Context, orgID string, billingAddress *BillingAddress) error {
_, err := c.client.EnableBillingService(ctx, &pb.EnableBillingServiceRequest{
OrgId: orgID,
BillingAddress: billingAddressToProto(billingAddress),
})
return err
}
this is already in the code ^
jr22
reviewed
Dec 20, 2024
Comment on lines
+398
to
+403
| cCtx, ac, out, errOut := setup(asc, nil, nil, nil, nil, "token") | ||
| test.That(t, ac.organizationEnableBillingServiceAction(cCtx, "test-org", | ||
| "123 Main St, Suite 100, San Francisco, CA, 94105"), test.ShouldBeNil) | ||
| test.That(t, len(errOut.messages), test.ShouldEqual, 0) | ||
| test.That(t, len(out.messages), test.ShouldEqual, 1) | ||
| test.That(t, out.messages[0], test.ShouldContainSubstring, "Successfully enabled billing service for organization") |
There was a problem hiding this comment.
tests for empty org + empty address?
jr22
approved these changes
Dec 20, 2024
stuqdog
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on the Billing Service from the CLI
Output:
With an empty orgID:
With a bad address:
with an empty address: