feat: sideEffects to package.json #6888
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sideEffects to have better code split
robwalch
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Our unit tests are included via import side-effects in https://github.com/video-dev/hls.js/blob/master/tests/index.js. That must be addressed before we can accept this change.
|
I compare builds (master and this pr). There are no difference beetween mjs, and about 1.5Kb at js. |
|
https://github.com/video-dev/hls.js/actions/runs/12154224025/job/33989518911#step:7:1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sideEffects to have better code split
This PR will...
Help budlers cut unused code when you use named import/export