fix(error-display): component remains displayed after player reset #8482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `player.reset` is called, the `errorDisplay` component is not reset, and neither is `player.error`. - Sets `player.error` to `null`, so that the `player.errorDisplay` and `player.error` are correctly reset. - Adds an `error` function to the `testPlayer` stub to prevent tests from failing.
Codecov Report
@@ Coverage Diff @@
## main #8482 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 113 113
Lines 7589 7590 +1
Branches 1826 1826
=======================================
+ Hits 6277 6278 +1
Misses 1312 1312
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
mister-ben
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
player.resetis called, theerrorDisplaycomponent is not reset, and neither isplayer.error.Screencast.from.04.11.23.17.08.14.webm
Specific Changes proposed
player.errortonull, so that theplayer.errorDisplayandplayer.errorare correctly reset.errorfunction to thetestPlayerstub to prevent tests from failing.Requirements Checklist