Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): new italian labels #8495

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

astagi
Copy link
Contributor

@astagi astagi commented Nov 23, 2023

Description

Fix Italian labels according to ones used by Bootstrap Italia (Italian government official library)

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Fix Italian labels according to ones used by Bootstrap Italia (Italian government official library)
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d535e16) 82.71% compared to head (d2797c7) 82.71%.
Report is 6 commits behind head on main.

❗ Current head d2797c7 differs from pull request most recent head 0c3e65f. Consider uploading reports for the commit 0c3e65f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8495   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7589     7589           
  Branches     1826     1826           
=======================================
  Hits         6277     6277           
  Misses       1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben
Copy link
Contributor

Grazie.
A question about "filmata" in these translations (not new in these changes). Does that convey specifically "video" or "video and/or audio" as is the intention of "media" in the English?

@astagi
Copy link
Contributor Author

astagi commented Nov 28, 2023

Grazie. A question about "filmata" in these translations (not new in these changes). Does that convey specifically "video" or "video and/or audio" as is the intention of "media" in the English?

YW! it does @mister-ben, "filmato" can be used synonymously with "video" (with or without audio), both terms are frequently used.

@mister-ben
Copy link
Contributor

Thanks, I mean more is it also valid if it's an audio source, that has no video.

@astagi
Copy link
Contributor Author

astagi commented Nov 29, 2023

Thanks, I mean more is it also valid if it's an audio source, that has no video.

oh ok! no, in that case "filmato" is not the right term. You can use "L'elemento media" (media element) in Italian to refer both video and/or only audio. I'll look for other terms and let you know, I update this PR in case.

@astagi
Copy link
Contributor Author

astagi commented Nov 29, 2023

Found it @mister-ben ! We should use "contenuto multimediale" (media content) instead of "filmato", it's ok both for video and audio. If it's ok for you I'll update this PR.

@mister-ben
Copy link
Contributor

Seems good to me, thanks!

@astagi
Copy link
Contributor Author

astagi commented Dec 4, 2023

Done @mister-ben ✌🏻

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We can ignore the coverage upload failure.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Dec 4, 2023
@dzianis-dashkevich dzianis-dashkevich merged commit 8240427 into videojs:main Dec 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants