Merge pull request #23 from vinicius77/security-updates

Security updates

backend/controllers/products.js

@@ -0,0 +1,31 @@
+const { v4: uuidv4 } = require('uuid');
+
+const DUMMY_PRODUCTS = []; //in-memory storage data
+
+const getProducts = async (req, res) => {
+	res.status(200).json({ products: DUMMY_PRODUCTS });
+};
+
+const createProduct = async (req, res) => {
+	const { title, price } = req.body;
+
+	if (!title || title.trim().length === 0 || !price || price <= 0) {
+		return res.status(422).json({
+			message: 'Invalid input, please enter a valid title and/or price.',
+		});
+	}
+
+	const createdProduct = {
+		id: uuidv4(),
+		title,
+		price,
+	};
+
+	DUMMY_PRODUCTS.push(createdProduct);
+
+	res.status(201).json({ message: 'Created New Product', product: createdProduct });
+};
+module.exports = {
+	createProduct,
+	getProducts,
+};

backend/routes/products.js

@@ -0,0 +1,8 @@
+const express = require('express');
+const router = express.Router();
+
+const { createProduct, getProducts } = require('../controllers/products');
+
+router.route('/').get(getProducts).post(createProduct);
+
+module.exports = router;

backend/server.js

@@ -1,11 +1,9 @@
 const express = require('express');
-const { v4: uuidv4 } = require('uuid');
 const app = express();
 const PORT = process.env.PORT || 5000;
 
-const DUMMY_PRODUCTS = []; //in-memory storage data
-
 app.use(express.json()); // Now express.js has the body-parser embebbed on it
+app.use(express.urlencoded({ extended: false }));
 
 // CORS Headers => Required for cross-origin- cross-server communication
 app.use((req, res, next) => {
@@ -18,28 +16,6 @@ app.use((req, res, next) => {
 	next();
 });
 
-app.get('/products', (req, res, next) => {
-	res.status(200).json({ products: DUMMY_PRODUCTS });
-});
-
-app.post('/product', (req, res, next) => {
-	const { title, price } = req.body;
-
-	if (!title || title.trim().length === 0 || !price || price <= 0) {
-		return res.status(422).json({
-			message: 'Invalid input, please enter a valid title and/or price.',
-		});
-	}
-
-	const createdProduct = {
-		id: uuidv4(),
-		title,
-		price,
-	};
-
-	DUMMY_PRODUCTS.push(createdProduct);
-
-	res.status(201).json({ message: 'Created New Product', product: createdProduct });
-});
+app.use('/products', require('./routes/products'));
 
 app.listen(PORT, () => console.log(`Server Listening on port ${PORT}`)); //Run node + express server on port 5000

frontend/src/App.js

@@ -28,7 +28,7 @@ function App() {
 				price: +productPrice,
 			};
 			let hasError = false;
-			const response = await fetch('http://localhost:5000/product', {
+			const response = await fetch('http://localhost:5000/products', {
 				method: 'POST',
 				body: JSON.stringify(newProduct),
 				headers: {