[Fix] Add names for UtreexoNode fields #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. Just don't really like |
Davidson-Souza
added
documentation
jaoleal
force-pushed
the
better_naming_on_utreexonode
branch
from
f6d4c1f to
d7d5f6f
Compare
|
I dont like context so much... i had to spend 2 entire hours reading the code trying to understand what context is... Since this can be a skill issue of me i implemented the changes and you can merge at it is or i can change again if you decide to. |
jaoleal
force-pushed
the
better_naming_on_utreexonode
branch
from
d7d5f6f to
35837dc
Compare
|
Forgot the generic type declaration. |
jaoleal
force-pushed
the
better_naming_on_utreexonode
branch
from
35837dc to
7f77d16
Compare
|
Changed the generic name on UtreexoNode |
jaoleal
force-pushed
the
better_naming_on_utreexonode
branch
from
7f77d16 to
3c72c6c
Compare
|
Rebased |
|
There's a config with |
|
Yes, i was waiting for #310 to get merged |
…osition of the field
jaoleal
force-pushed
the
better_naming_on_utreexonode
branch
from
3c72c6c to
f2e2e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While searching a way to implement
MTP, i got myself a lot of the times with theUtreexoNodedeclaration aside my readings trough florestad`s internals just becauseThe generic trait declaration is inverted and the fields had no name, usually being called as
self.0orself.1which is not so intuitive to look at.IMO is better to always name internal fields if they're being accessed from outside the struct and not only from internal methods for that structure