-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus support #314
Conversation
b42a66d
to
2132b54
Compare
This is so cool! I'm using a grafana dashboard with this, and it looks sick! Thanks for working on this.
I had the same thing happening here, it seems worse on docker than native. I've narrowed that down to For this PR, could we get prometheus as an (optional) feature for forestad? |
bb03780
to
6df53a9
Compare
@Davidson-Souza Done ✅ Lemme know if this is what you had in mind. |
Yes! Looks great! Just one small thing I've noticed: I'm getting some
|
6df53a9
to
dc0aace
Compare
dc0aace
to
9e3db25
Compare
Thanks for spotting that @Davidson-Souza ! |
ACK 9e3db25 |
Closes #166 .
This PR adds support for Prometheus, while giving an example of its integration with Grafana as well.
Summary
metrics
that holds information about the Prometheus metrics and that can be used in a singleton way;docker-compose.yml
file to examplify how to deploy floresta+prometheus+grafana infra;Example of added metrics in Grafana:
Testing
Run
docker-compose up -d --build
, wait for it to start all services and then go to http://localhost:3000/, where you can log into Grafana using the given credentials found in thedocker-compose.yml
file.There, you can go to Dashboards on the left, add New, select Prometheus as the data source (should be pre-selected) and then choose one of the metrics, the data visualization type and run the queries to see it in action.
Improvements
I'm not too familiar with the codebase, therefore adding metrics to the best places would be better done by someone who has.
During the tests with the deployment of the infra with
docker-compose.yml
noticed that there is something off going on with the system, probably related to this, that it was driving the CPU usage over 100% and the memory at around 8GB, maintaining this last one during the initial block downloading at least.The high CPU and memory usage would go off the roofs around this part.