lint-upgrade

visgl · Oct 13, 2023 · a5b34f6 · a5b34f6
1 parent d099bdd
commit a5b34f6
Show file tree

Hide file tree

Showing 16 changed files with 145 additions and 118 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -38,6 +38,14 @@ const config = getESLintConfig({
       {
         files: ['**/*.ts', '**/*.tsx', '**/*.d.ts'],
         rules: {
+          // typescript-eslint 6.0
+          '@typescript-eslint/no-unsafe-argument': 0,
+          '@typescript-eslint/no-redundant-type-constituents': 0,
+          '@typescript-eslint/no-unsafe-enum-comparison': 1,
+          '@typescript-eslint/no-duplicate-type-constituents': 1,
+          '@typescript-eslint/no-base-to-string': 1,
+          '@typescript-eslint/no-loss-of-precision': 1,
+
           // For parquet module
           '@typescript-eslint/no-non-null-assertion': 0,
           '@typescript-eslint/no-non-null-asserted-optional-chain': 0,

diff --git a/modules/arrow/src/types.ts b/modules/arrow/src/types.ts
@@ -1,12 +1,4 @@
-type TypedIntArray =
-  | Int8Array
-  | Uint8Array
-  | Int16Array
-  | Uint16Array
-  | Int32Array
-  | Uint32Array
-  | Int32Array
-  | Uint32Array;
+type TypedIntArray = Int8Array | Uint8Array | Int16Array | Uint16Array | Int32Array | Uint32Array;
 
 type TypedFloatArray = Float32Array | Float64Array;
 

diff --git a/modules/flatgeobuf/src/flatgeobuf-loader.ts b/modules/flatgeobuf/src/flatgeobuf-loader.ts
@@ -6,7 +6,7 @@ const VERSION = typeof __VERSION__ !== 'undefined' ? __VERSION__ : 'latest';
 
 export type FlatGeobufLoaderOptions = LoaderOptions & {
   flatgeobuf?: {
-    shape?: 'geojson-table' | 'columnar-table' | 'geojson-table' | 'geojson' | 'binary';
+    shape?: 'geojson-table' | 'columnar-table' | 'geojson' | 'binary';
   };
   gis?: {
     reproject?: boolean;

diff --git a/modules/gltf/src/lib/gltf-utils/gltf-utils.ts b/modules/gltf/src/lib/gltf-utils/gltf-utils.ts
@@ -19,8 +19,6 @@ type TypedArrayConstructor =
   | Uint16ArrayConstructor
   | Int32ArrayConstructor
   | Uint32ArrayConstructor
-  | Int32ArrayConstructor
-  | Uint32ArrayConstructor
   | Float32ArrayConstructor
   | Float64ArrayConstructor;
 

diff --git a/modules/loader-utils/src/lib/node/buffer.browser.ts b/modules/loader-utils/src/lib/node/buffer.browser.ts
@@ -15,6 +15,6 @@ export function toArrayBuffer(buffer) {
 /**
  * Convert (copy) ArrayBuffer to Buffer
  */
-export function toBuffer(binaryData: ArrayBuffer | ArrayBuffer | Buffer): Buffer {
+export function toBuffer(binaryData: ArrayBuffer | Buffer): Buffer {
   throw new Error('Buffer not supported in browser');
 }
diff --git a/modules/loader-utils/src/lib/node/buffer.ts b/modules/loader-utils/src/lib/node/buffer.ts
@@ -20,7 +20,7 @@ export function toArrayBuffer(buffer) {
 /**
  * Convert (copy) ArrayBuffer to Buffer
  */
-export function toBuffer(binaryData: ArrayBuffer | ArrayBuffer | Buffer): Buffer {
+export function toBuffer(binaryData: ArrayBuffer | Buffer): Buffer {
   if (Buffer.isBuffer(binaryData)) {
     return binaryData;
   }

diff --git a/modules/loader-utils/src/types.ts b/modules/loader-utils/src/types.ts
@@ -7,8 +7,6 @@ export type TypedIntArray =
   | Int16Array
   | Uint16Array
   | Int32Array
-  | Uint32Array
-  | Int32Array
   | Uint32Array;
 
 export type TypedFloatArray = Uint16Array | Float32Array | Float64Array;
@@ -24,8 +22,6 @@ export type TypedArrayConstructor =
   | Uint16ArrayConstructor
   | Int32ArrayConstructor
   | Uint32ArrayConstructor
-  | Int32ArrayConstructor
-  | Uint32ArrayConstructor
   | Float32ArrayConstructor
   | Float64ArrayConstructor;
 

diff --git a/modules/math/src/index.ts b/modules/math/src/index.ts
@@ -5,8 +5,6 @@ export type TypedArrayConstructor =
   | Uint16ArrayConstructor
   | Int32ArrayConstructor
   | Uint32ArrayConstructor
-  | Int32ArrayConstructor
-  | Uint32ArrayConstructor
   | Float32ArrayConstructor
   | Float64ArrayConstructor;
 

diff --git a/modules/schema/src/lib/table/arrow-api/arrow-like-type.ts b/modules/schema/src/lib/table/arrow-api/arrow-like-type.ts
@@ -14,8 +14,6 @@ export type TypedIntArray =
   | Uint16Array
   | Int32Array
   | Uint32Array
-  | Int32Array
-  | Uint32Array
   | Uint8ClampedArray;
 
 export type TypedFloatArray = Float32Array | Float64Array;

diff --git a/modules/schema/src/types/types.ts b/modules/schema/src/types/types.ts
@@ -19,8 +19,6 @@ export type TypedArrayConstructor =
   | Uint16ArrayConstructor
   | Int32ArrayConstructor
   | Uint32ArrayConstructor
-  | Int32ArrayConstructor
-  | Uint32ArrayConstructor
   | Float32ArrayConstructor
   | Float64ArrayConstructor;
 

diff --git a/modules/textures/src/lib/parsers/parse-npy.ts b/modules/textures/src/lib/parsers/parse-npy.ts
@@ -10,8 +10,6 @@ type TypedArrayConstructor =
   | typeof Uint16Array
   | typeof Int32Array
   | typeof Uint32Array
-  | typeof Int32Array
-  | typeof Uint32Array
   | typeof Float32Array
   | typeof Float64Array;
 

diff --git a/modules/tiles/test/data/tile-header-examples.ts b/modules/tiles/test/data/tile-header-examples.ts
@@ -1,6 +1,7 @@
 import {I3STileHeader} from '@loaders.gl/i3s/src';
 import {TILE_TYPE} from '../../src';
 
+/* eslint-disable @typescript-eslint/no-loss-of-precision */
 export const ROOT_TILE_HEADER: I3STileHeader = {
   id: '0',
   lodSelection: [

diff --git a/modules/wms/src/services/ogc/csw-service.ts b/modules/wms/src/services/ogc/csw-service.ts
@@ -63,7 +63,7 @@ export type CSWServiceProps = DataSourceProps & {
  * @note Only the URL parameter conversion is supported. XML posts are not supported.
  */
 export class CSWService extends DataSource<CSWServiceProps> {
-  static type: 'csw' = 'csw';
+  static readonly type = 'csw';
   static testURL = (url: string): boolean => url.toLowerCase().includes('csw');
 
   capabilities: CSWCapabilities | null = null;

diff --git a/modules/worker-utils/src/lib/library-utils/library-utils.ts b/modules/worker-utils/src/lib/library-utils/library-utils.ts
@@ -93,7 +93,7 @@ async function loadLibraryFromFile(libraryUrl: string): Promise<any> {
     try {
       return node && node.requireFromFile && (await node.requireFromFile(libraryUrl));
     } catch (error) {
-      console.error(error);
+      console.error(error); // eslint-disable-line no-console
       return null;
     }
   }

diff --git a/package.json b/package.json
@@ -60,7 +60,9 @@
   ],
   "resolutions": {
     "prettier": "3.0.3",
-    "typescript": "^5.0.4"
+    "typescript": "^5.0.4",
+    "@typescript-eslint/eslint-plugin": "^6.0.0",
+    "@typescript-eslint/parser" : "^6.0.0"
   },
   "volta": {
     "node": "16.20.2",