feat(wkt): Add TWKB parser WIP #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Dec 16, 2021
| @@ -33,7 +33,7 @@ enum WKB { | |||
| /** | |||
| * Options for encodeWKB | |||
| */ | |||
| interface WKBOptions { | |||
| type WKBOptions = { | |||
There was a problem hiding this comment.
Is type better than interface?
There was a problem hiding this comment.
If not better, it is at least less ambiguous. Admittedly I have some baggage from other languages, but to me, interface is an object oriented concept that is intended to describe (mostly) methods that need to be defined by a class, so I think it looks strange to see interface used to describe a pure object without any methods.
I suspect interface is favored in some type script code because of historical reasons (maybe type was a later addition?)
kylebarron
reviewed
Dec 16, 2021
| @@ -20,7 +20,7 @@ import BinaryWriter from './utils/binary-writer'; | |||
| * Integer code for geometry type | |||
| * Reference: https://en.wikipedia.org/wiki/Well-known_text_representation_of_geometry#Well-known_binary | |||
| */ | |||
| enum WKB { | |||
| export enum WKB { | |||
There was a problem hiding this comment.
Remove and import from wkb-types?
kylebarron
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code structure looks quite similar to WKB, remaining work, especially on encoder side, should be very similar to what we did for WKB.