fix(gltf): getting typed arrays for accessor #2691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Oct 13, 2023
| ): TypedArray { | ||
| const gltfAccessor = typeof accessor === 'number' ? json.accessors?.[accessor] : accessor; | ||
| if (!gltfAccessor) { | ||
| throw new Error(`No Accessor ${accessor}`); |
There was a problem hiding this comment.
Can be very hard for end users to understand such an error message. Maybe mentioning glTF could give them a hint?
Suggested change
| throw new Error(`No Accessor ${accessor}`); | |
| throw new Error(`No glTF accessor ${accessor}`); |
| } | ||
| const bufferView = json.bufferViews?.[gltfAccessor.bufferView || 0]; | ||
| if (!bufferView) { | ||
| throw new Error(`No Buffer View for Accessor ${bufferView}`); |
There was a problem hiding this comment.
Suggested change
| throw new Error(`No Buffer View for Accessor ${bufferView}`); | |
| throw new Error(`No glTF buffer view for accessor ${bufferView}`); |
| * @returns {TypedArray} Typed array with type matching the type of data poited by the accessor. | ||
| */ | ||
| // eslint-disable-next-line complexity | ||
| export function getTypedArrayForAccessor( |
There was a problem hiding this comment.
A function like this should really have a couple of test cases. It can be very painful to debug code when the error happens in a low-level utility like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the getTypedArrayForAccessor function in get-typed-arrays.ts with the interface similar to getTypedArrayForBufferView and getTypedArrayForImageData.
Currently these functions are not being used in gltf-scenegraph.ts.
Later on, after deep investigation we will make a decision with regard to their possible usage in gltf-scenegraph.ts.