getIonAssetMetadata struct changed (options.url) #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions instead of top level
ibgreen
approved these changes
Oct 11, 2024
Co-authored-by: Ib Green <[email protected]>
Co-authored-by: Ib Green <[email protected]>
|
@techtruth Thanks for the PR. To release it needs to be cherry-picked into the 4.2-release branch and published. I have cherry-picked it so next time we release a patch it will be published. Check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears Cesium Ion has changed the return value of ${CESIUM_ION_URL}/${assetId}, when getting metadata from CesiumIonLoader.preload. Now this value has the url inside options.url instead of the top level.
This also puts the correct bearer token inside the metadata headers, coming from the input arg instead of what is returned by the query to the cesium ion api.