fix(loader-utils): ReadableFile implementation to match the interface #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Nov 5, 2024
| async read(start: number, length: number): Promise<ArrayBuffer> { | ||
| const arrayBuffer = await this.handle.slice(start, start + length).arrayBuffer(); | ||
| async read(start?: number | BigInt, length?: number): Promise<ArrayBuffer> { | ||
| const arrayBuffer = await this.handle |
There was a problem hiding this comment.
I faced a problem when I have ReadableFile as input in FileProvider and read() there accepts start as number | bigint so I pass bigint here and get runtime error that it cannot sum bigint and number because real implementation knows nothing about bigint. We need keep real implementation of the methods matching it's description in ReadableFile
Comment on lines
33
to
34
| async read(offset?: number | bigint, length?: number): Promise<ArrayBuffer> { | ||
| const response = await this.fetchRange(offset ?? 0, length ?? 0); |
There was a problem hiding this comment.
Use default argument syntax for better clarity?
Suggested change
| async read(offset?: number | bigint, length?: number): Promise<ArrayBuffer> { | |
| const response = await this.fetchRange(offset ?? 0, length ?? 0); | |
| async read(offset: number | bigint = 0, length: number = 0): Promise<ArrayBuffer> { | |
| const response = await this.fetchRange(offset, length); |
| @@ -25,7 +25,7 @@ export class NodeFileFacade implements ReadableFile, WritableFile { | |||
| throw new Error('Can\'t instantiate NodeFile. Make sure to import @loaders.gl/polyfills first.'); | |||
| } | |||
| /** Read data */ | |||
| async read(start?: number | bigint, end?: number | bigint): Promise<ArrayBuffer> { | |||
| async read(start?: number | bigint, offset?: number): Promise<ArrayBuffer> { | |||
There was a problem hiding this comment.
- What is the difference between
startandoffset? - How does this function now know where to stop reading?
- Should it be
lengthinstead?
There was a problem hiding this comment.
That's my mistake, I'll change it to length, as it's in the ReadableFile and NodeFile implementation
ibgreen
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing input types of
ReadableFileimplementations to match the interface. Currently it's not matched and that cause runtime errors. I need this change because I'm currently working on local slpk reading for I3S explorer and I needBlobFilefor it