feat(potree): render all nodes #3162
Conversation
| @@ -17,8 +17,8 @@ | |||
| "@deck.gl/layers": "^9.0.32", | |||
| "@deck.gl/mesh-layers": "^9.0.32", | |||
| "@deck.gl/react": "^9.0.32", | |||
| "@loaders.gl/potree": "4.4.0-alpha.0", | |||
There was a problem hiding this comment.
Suggestion:
- I'd probably rename this example from
potreetopoint-tile-sourcewith the goal of expanding it to cover COPCSource. - And perhaps we can even make point tile sources for 3D tiles and I3S?
| @@ -1,5 +1,7 @@ | |||
| import {Vector3} from '@math.gl/core'; | |||
| import {DataSource} from '@loaders.gl/loader-utils'; | |||
| import {POTreeNode} from '@loaders.gl/potree'; | |||
| import {PotreeTraverser} from './potree-traverser'; | |||
There was a problem hiding this comment.
- This idea of having a special traverser for each format always seemed wrong to me - i.e. I was hoping that we would not need to copy this particular pattern from the current
TIleset3Dcode - The source should normalize the returned data so that a common traverser can handle the data.
| @@ -45,7 +58,7 @@ export class PointcloudTileset { | |||
| } | |||
|
|
|||
| get tiles() { | |||
| return []; | |||
| return this._selectedNodes; | |||
There was a problem hiding this comment.
Nit: I would prefer that we don't overuse getters. There should be a good reason for using a getter. I.e.
- Why use a getter here?
- Why not just have a method
getTiles()?
There was a problem hiding this comment.
tileset.tiles is used by deck.gl
| @@ -76,4 +76,54 @@ export class PotreeTile3DLayer< | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Would it make sense to rename this file/class to point-tile-source-layer?
| @@ -0,0 +1,37 @@ | |||
| import {POTreeNode} from "@loaders.gl/potree"; | |||
|
|
|||
| export class PotreeTraverser { | |||
There was a problem hiding this comment.
If we must have a traverser class, can we generalize it a little bit: PointTileSourceTraverser?
|
|
||
| if (result) { | ||
| let projection; | ||
| if (this.metadata?.projection) { |
There was a problem hiding this comment.
I would recommend defining helper methods for reprojection and bounding box calculations.
|
@alekzvik This allows small point clouds to be rendered in an example (loads and renders all tiles). Should provide a better starting point for integrating |
No description provided.