feat: Support for custom mapbox layer #1851
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using DeckGl as the container for Mapbox, we use Mapbox as the container for DeckGl layer. This lets us insert the deckgl layer between the mapbox layers, which is very handy when dealing with labels. We use DeckGL's custom Mapbox layer here. Since DeckGL's custom layer need method on the prototype, we can copy the layer props with spreading, otherwise we lose the methods. This is why the `layer` prop is added on the Layer so that we can pass the custom layer without any copying.
Closed
|
Thank you for the proposal. To simplify things, I suggest we don't change the prop types for the existing use cases, and just add type CustomLayer = {
type: 'custom',
layer: CustomLayerInterface
}What do you think? |
|
Any news on that? |
|
I'm very much interested in seeing this merged. is there a way to help this along? |
|
Was trying to recreate in react-map-gl the example here to display a 3d model, but it looks like this isn't currently possible. Is there a known workaround for this? Many thanks! |
ZiaurRehmanmalhi
suggested changes
Nov 9, 2023
| // @ts-ignore | ||
| map.addLayer(options, props.beforeId); | ||
| map.addLayer(layerProps, beforeId); | ||
| } | ||
| } | ||
|
|
||
| /* eslint-enable complexity, max-statements */ | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it can be handy to insert a visualisation layer under another layer from mapbox (for example under the labels).
To do that, we can use DeckGL's custom mapbox layer that we insert between mapbox own layers.
Since DeckGL's custom layer need methods on the prototype (onAdd, onRemove, render), we cannot copy the layer props with spreading, otherwise we lose the methods. This is why the
layerprop is added on the Layer so that we can pass the custom layer without any copying. This is also why there is some rework around beforeId so that it is external to the layer and only part of the Layer component props, not of the layer options props.I'd like to have your opinion on this way of doing before continuing the work on this PR (maybe improving the documentation or the example).