Release 0.8.1

vitalets · Nov 14, 2017 · e6d853a · e6d853a
1 parent 201602f
commit e6d853a
Show file tree

Hide file tree

Showing 12 changed files with 96 additions and 39 deletions.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -1,6 +1,13 @@
 Angular-xeditable changelog
 =============================
 
+Version 0.8.1 Nov 14, 2017
+
+----------------------------
+[bug #702] Fix Node/Phantomjs/Karma syntax error (ckosloski)
+[bug #690] Fix e-formclass for textarea (ckosloski)
+[bug #679] Fix combodate not updating value if the combobox is not changed (chiu0602)
+
 Version 0.8.0 Jun 6, 2017
 
 ----------------------------

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-xeditable",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Edit in place for AngularJS",
   "author": "https://github.com/vitalets",
   "license": "MIT",

diff --git a/dist/css/xeditable.min.css b/dist/css/xeditable.min.css
diff --git a/dist/js/xeditable.js b/dist/js/xeditable.js
@@ -1,7 +1,7 @@
 /*!
-angular-xeditable - 0.8.0
+angular-xeditable - 0.8.1
 Edit-in-place for angular.js
-Build date: 2017-06-06 
+Build date: 2017-11-14 
 */
 /**
  * Angular-xeditable module 
@@ -428,12 +428,11 @@ angular.module('xeditable').directive('editableCombodate', ['editableDirectiveFa
           //.replace is so this works in Safari
           self.scope.$data = combodate.getValue() ?
               (new Date(combodate.getValue().replace(/-/g, "/"))).toISOString() : null;
-        });
+        }).change();
       }
     });
   }
 ]);
-
 /*
 Input types: text|password|email|tel|number|url|search|color|date|datetime|datetime-local|time|month|week|file
 */
@@ -489,6 +488,7 @@ Input types: text|password|email|tel|number|url|search|color|date|datetime|datet
             // Add classes to the form
             if (this.attrs.eFormclass) {
               this.editorEl.addClass(this.attrs.eFormclass);
+              this.inputEl.removeAttr('formclass');
             }
           },
           autosubmit: function() {
@@ -636,6 +636,15 @@ angular.module('xeditable').directive('editableTextarea', ['editableDirectiveFac
     return editableDirectiveFactory({
       directiveName: 'editableTextarea',
       inputTpl: '<textarea></textarea>',
+      render: function() {
+          this.parent.render.call(this);
+
+          // Add classes to the form
+          if (this.attrs.eFormclass) {
+              this.editorEl.addClass(this.attrs.eFormclass);
+              this.inputEl.removeAttr('formclass');
+          }
+      },
       addListeners: function() {
         var self = this;
         self.parent.addListeners.call(self);
@@ -1319,7 +1328,7 @@ function($parse, $compile, editableThemes, $rootScope, $document, editableContro
           if (getter) { // form exists in scope (above), e.g. editable column
             eFormCtrl = getter;
             hasForm = true;
-          } else if (elem && typeof elem.parents === "function" && elem.parents().last().find('form[name='+attrs.eForm+']').length) { // form exists below or not exist at all: check document.forms
+          } else if (elem && typeof elem.parents === "function" && elem.parents().last().find('form[name="'+attrs.eForm+'"]').length) { // form exists below or not exist at all: check document.forms
             // form is below and not processed yet
             eFormCtrl = null;
             hasForm = true;

diff --git a/dist/js/xeditable.min.js b/dist/js/xeditable.min.js
diff --git a/index.html b/index.html
@@ -57,7 +57,7 @@
             <li class="active"><a href="#">Home</a></li>
             <li><a href="https://github.com/vitalets/angular-xeditable">GitHub</a></li>
           </ul>
-          <form class="navbar-form navbar-right"><a href="zip/angular-xeditable-0.8.0.zip" style="font-weight:bold" class="btn btn-primary"><span style="margin-right:10px" class="glyphicon glyphicon-save"></span>Download 0.8.0 ~ kb</a></form>
+          <form class="navbar-form navbar-right"><a href="zip/angular-xeditable-0.8.1.zip" style="font-weight:bold" class="btn btn-primary"><span style="margin-right:10px" class="glyphicon glyphicon-save"></span>Download 0.8.1 ~ kb</a></form>
           <div style="padding-top: 13px">
 <!-- google+ -->
 <div id="socials" style="text-align: center">
@@ -141,6 +141,7 @@
                   <li><a href="#edit-disabled">Disable editing</a></li>
                   <li><a href="#editable-popover">Editable Popover</a></li>
                   <li><a href="#uipopover">Editable ui-bootstrap Popover</a></li>
+                  <li><a href="#e-single">Single editable in a form</a></li>
                 </ul>
               </li>
               <li><a href="#onbeforesave">Submit</a>
@@ -228,7 +229,7 @@ <h1>Get started</h1>
 
               <pre class="prettyprint">&lt;link href=&quot;https://netdna.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css&quot; rel=&quot;stylesheet&quot;&gt;</pre>
             </li>
-            <li> <span>Install angular-xeditable via </span><a href="http://bower.io" target="_blank">bower</a><span> or  </span><a href="zip/angular-xeditable-0.8.0.zip">download latest zip    </a>
+            <li> <span>Install angular-xeditable via </span><a href="http://bower.io" target="_blank">bower</a><span> or  </span><a href="zip/angular-xeditable-0.8.1.zip">download latest zip    </a>
               <pre class="prettyprint">bower install angular-xeditable </pre>
             </li>
             <li>Include angular-xeditable into your project
@@ -240,9 +241,9 @@ <h1>Get started</h1>
               <pre class="prettyprint">var app = angular.module("app", ["xeditable"]);</pre>
             </li>
             <li>Set theme in app.run:
-              <pre class="prettyprint">app.run(function(editableOptions) {
+              <pre class="prettyprint">app.run(['editableOptions', function(editableOptions) {
   editableOptions.theme = 'bs3'; // bootstrap3 theme. Can be also 'bs2', 'default'
-});
+}]);
 </pre>
             </li>
             <li>Markup element that should be editable 
@@ -1566,6 +1567,37 @@ <h3>controller.js</h3>
     name: 'awesome user',
       location: 'location 1'
   };
+});</pre>
+                    </section>
+                    <section id="e-single">
+                      <h1>Single editable in a form</h1>
+                      <!-- watch change of user to update rootScope for debugging-->
+                      <h3>demo</h3>
+                      <div class="well line-example"><div ng-controller="ESingleCtrl" id="ESingleCtrl">
+  <form>
+    <a href="#" editable-text="user.name" e-single>{{ user.name || 'empty' }}</a>
+  </form>
+</div></div>
+                      <pre>{{ debug["e-single"] | json }}</pre>
+                      <p><p>Add <code>e-single</code> attribute when you want a single item to be clickable inside of a form.<br>It ignores the outer form.</p>
+</p>
+                      <!--script(src=dir+'/controller.js')-->
+                      <script>app.controller('ESingleCtrl', function($scope) {
+  $scope.user = {
+    name: 'awesome user'
+  };  
+$scope.$watch("user", function(v) { $scope.$parent.debug["e-single"]=v; }); });</script>
+                      <h3>html</h3>
+                      <pre class="prettyprint ng-non-bindable">&lt;div ng-controller=&quot;ESingleCtrl&quot; id=&quot;ESingleCtrl&quot;&gt;
+  &lt;form&gt;
+    &lt;a href=&quot;#&quot; editable-text=&quot;user.name&quot; e-single&gt;{{ user.name || 'empty' }}&lt;/a&gt;
+  &lt;/form&gt;
+&lt;/div&gt;</pre>
+                      <h3>controller.js</h3>
+                      <pre class="prettyprint">app.controller('ESingleCtrl', function($scope) {
+  $scope.user = {
+    name: 'awesome user'
+  };  
 });</pre>
                     </section>
                     <section id="onbeforesave">
@@ -2739,26 +2771,26 @@ <h1>Themes</h1>
 <p>To display a clear button, set the <code>editableOptions.displayClearButton=true</code> in <code>app.run</code>.</p>
 <p>To change the <code>title</code> and <code>aria-label</code> values of the submit/cancel/clear buttons, set the <code>editableOptions</code> properties:</p>
 
-          <pre class="prettyprint">app.run(function(editableOptions) {
+          <pre class="prettyprint">app.run(['editableOptions', function(editableOptions) {
   editableOptions.submitButtonTitle = 'Submit';
   editableOptions.submitButtonAriaLabel = 'Submit';
   editableOptions.cancelButtonTitle = 'Cancel';
   editableOptions.cancelButtonAriaLabel = 'Cancel';
   editableOptions.clearButtonTitle = 'Clear';
   editableOptions.clearButtonAriaLabel = 'Clear';
-});
+}]);
 </pre>
           <section id="bootstrap3"></section>
           <h2>Bootstrap 3</h2><p>Include <a href="http://getbootstrap.com">Bootstrap 3</a> CSS</p>
 
           <pre class="prettyprint">&lt;link href=&quot;https://netdna.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css&quot; rel=&quot;stylesheet&quot;&gt;</pre><p>Set theme in <code>app.run</code>:</p>
 
-          <pre class="prettyprint">app.run(function(editableOptions) {
+          <pre class="prettyprint">app.run(['editableOptions', function(editableOptions) {
   editableOptions.theme = 'bs3';
-});
+}]);
 </pre><p>To have smaller or bigger controls modify <code>inputClass</code> and <code>buttonsClass</code> properties of theme:</p>
 
-          <pre class="prettyprint">app.run(function(editableOptions, editableThemes) {
+          <pre class="prettyprint">app.run(['editableOptions', 'editableThemes', function(editableOptions, editableThemes) {
   editableThemes.bs3.inputClass = 'input-sm';
   editableThemes.bs3.buttonsClass = 'btn-sm';
   editableOptions.theme = 'bs3';
@@ -2769,20 +2801,20 @@ <h2>Bootstrap 2</h2><p>Include <a href="http://getbootstrap.com/2.3.2">Bootstrap
 
           <pre class="prettyprint">&lt;link href=&quot;//netdna.bootstrapcdn.com/twitter-bootstrap/2.3.2/css/bootstrap-combined.min.css&quot; rel=&quot;stylesheet&quot;&gt;</pre><p>Set theme in <code>app.run</code>:</p>
 
-          <pre class="prettyprint">app.run(function(editableOptions) {
+          <pre class="prettyprint">app.run(['editableOptions', function(editableOptions) {
   editableOptions.theme = 'bs2';
-});
+}]);
 </pre>
           <section id="default"></section>
           <h2>Default</h2><p>No additional CSS required.<br>You can customize theme in <code>app.run</code> by overwriting properties:</p>
 
-          <pre class="prettyprint">app.run(function(editableOptions, editableThemes) {
+          <pre class="prettyprint">app.run(['editableOptions', 'editableThemes', function(editableOptions, editableThemes)
   // set `default` theme
   editableOptions.theme = 'default';
 
   // overwrite submit button template
   editableThemes['default'].submitTpl = '&lt;button type="submit"&gt;ok&lt;/button&gt;';
-});
+}]);
 </pre><p>Available properties of each theme you can see in source
 <a href="https://github.com/vitalets/angular-xeditable/tree/master/src/js/themes.js">themes.js</a></p>
 <p>To change appearance of editable links you should overwrite CSS:</p>
@@ -3022,10 +3054,10 @@ <h3>Methods</h3><p>Methods are available when you set <code>name</code> attribut
           <h2>Reference: editable options</h2>
           <h3>Options</h3><p>Options are set in app.run</p>
 
-          <pre class="prettyprint">app.run(function(editableOptions) {
+          <pre class="prettyprint">app.run(['editableOptions', function(editableOptions) {
 editableOptions.theme = 'bs3';
 ...
-});
+}]);
 </pre>
                     <table width="100%" class="table-bordered table-condensed">
                       <thead>

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "angular-xeditable",
   "description": "Edit-in-place for angular.js",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "homepage": "https://vitalets.github.io/angular-xeditable",
   "author": {
     "name": "Vitaliy Potapov",

diff --git a/starter/angular-xeditable/css/xeditable.min.css b/starter/angular-xeditable/css/xeditable.min.css
diff --git a/starter/angular-xeditable/js/xeditable.js b/starter/angular-xeditable/js/xeditable.js
@@ -1,7 +1,7 @@
 /*!
-angular-xeditable - 0.8.0
+angular-xeditable - 0.8.1
 Edit-in-place for angular.js
-Build date: 2017-06-06 
+Build date: 2017-11-14 
 */
 /**
  * Angular-xeditable module 
@@ -428,12 +428,11 @@ angular.module('xeditable').directive('editableCombodate', ['editableDirectiveFa
           //.replace is so this works in Safari
           self.scope.$data = combodate.getValue() ?
               (new Date(combodate.getValue().replace(/-/g, "/"))).toISOString() : null;
-        });
+        }).change();
       }
     });
   }
 ]);
-
 /*
 Input types: text|password|email|tel|number|url|search|color|date|datetime|datetime-local|time|month|week|file
 */
@@ -489,6 +488,7 @@ Input types: text|password|email|tel|number|url|search|color|date|datetime|datet
             // Add classes to the form
             if (this.attrs.eFormclass) {
               this.editorEl.addClass(this.attrs.eFormclass);
+              this.inputEl.removeAttr('formclass');
             }
           },
           autosubmit: function() {
@@ -636,6 +636,15 @@ angular.module('xeditable').directive('editableTextarea', ['editableDirectiveFac
     return editableDirectiveFactory({
       directiveName: 'editableTextarea',
       inputTpl: '<textarea></textarea>',
+      render: function() {
+          this.parent.render.call(this);
+
+          // Add classes to the form
+          if (this.attrs.eFormclass) {
+              this.editorEl.addClass(this.attrs.eFormclass);
+              this.inputEl.removeAttr('formclass');
+          }
+      },
       addListeners: function() {
         var self = this;
         self.parent.addListeners.call(self);
@@ -1319,7 +1328,7 @@ function($parse, $compile, editableThemes, $rootScope, $document, editableContro
           if (getter) { // form exists in scope (above), e.g. editable column
             eFormCtrl = getter;
             hasForm = true;
-          } else if (elem && typeof elem.parents === "function" && elem.parents().last().find('form[name='+attrs.eForm+']').length) { // form exists below or not exist at all: check document.forms
+          } else if (elem && typeof elem.parents === "function" && elem.parents().last().find('form[name="'+attrs.eForm+'"]').length) { // form exists below or not exist at all: check document.forms
             // form is below and not processed yet
             eFormCtrl = null;
             hasForm = true;

diff --git a/starter/angular-xeditable/js/xeditable.min.js b/starter/angular-xeditable/js/xeditable.min.js
diff --git a/zip/angular-xeditable-0.8.1.zip b/zip/angular-xeditable-0.8.1.zip
diff --git a/zip/angular-xeditable-starter.zip b/zip/angular-xeditable-starter.zip