Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0x50FE3B4D from ksceSysrootIsManufacturingMode to ksceSysrootUseI… #329

Merged
merged 2 commits into from
Jul 1, 2018

Conversation

CelesteBlue-dev
Copy link
Contributor

…nternalStorage

Thanks to SKGleba

@d3m3vilurr
Copy link
Contributor

1.5yr ago, this nid was added from @TheOfficialFloW #139 then removed from @yifanlu cuz dup nid #172
should review from one of them.

@yifanlu
Copy link
Contributor

yifanlu commented Jun 30, 2018

Please don’t remove headers. This isn’t how sdks work.

@CelesteBlue-dev
Copy link
Contributor Author

@d3m3vilurr I have already explained to yifan why this is not IsManufacturingMode function and why it is UseExternalStorage.
The IsManufacturingMode function exists under this form only:

int sceSblPmMgrGetCurrentMode(int *mode);

Returns 0 on success. mode is set to 1 if PSVita is in manufacturing mode.

@d3m3vilurr d3m3vilurr merged commit aee0d75 into vitasdk:master Jul 1, 2018
@yifanlu
Copy link
Contributor

yifanlu commented Jul 1, 2018

Okay cool so we’re breaking homebrew code again?

@CelesteBlue-dev
Copy link
Contributor Author

nothing uses this function for now as it was not useful to know if vita was in manufacturing mode.
Now that we know it indicates if memcard is allowed to be used, it will maybe be used in storage plugins...

@d3m3vilurr
Copy link
Contributor

@yifanlu I said before about the version, but nobody start this :( anyway, maybe we need define macro for avoid sdk break

@d3m3vilurr
Copy link
Contributor

@yifanlu pushed 0ebd19f then made issue #331

@yifanlu
Copy link
Contributor

yifanlu commented Jul 1, 2018

Thanks!

@CelesteBlue-dev CelesteBlue-dev deleted the patch-6 branch July 4, 2018 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants