Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] psp2kern: Rename ksceSysrootUse*Storage #394

Closed
wants to merge 1 commit into from
Closed

[WIP] psp2kern: Rename ksceSysrootUse*Storage #394

wants to merge 1 commit into from

Conversation

d3m3vilurr
Copy link
Contributor

rollback ksceSysrootUseExternalStorage to ksceSysrootIsManufacturingMode
rename ksceSysrootUseInternalStorage to ksceSysrootIsInternalStorageEnabled

@d3m3vilurr
Copy link
Contributor Author

we still have conversation these names in discord
wait to merge until get agreement.

@d3m3vilurr
psp2kern: Rename ksceSysrootUse*Storage
24f4088 
rollback ksceSysrootUseExternalStorage to ksceSysrootIsManufacturingMode
rename ksceSysrootUseInternalStorage to ksceSysrootIsInternalStorageEnabled
@d3m3vilurr
Copy link
Contributor Author

I don't agree ksceSysrootIsInternalStorageEnabled naming. I suggested ksceSysrootGetEnabledStorageType then define storage type enum.
@CelesteBlue-dev doesn't agree ksceSysrootIsManufacturingMode. he suggested ksceSysrootIsExternalStorageEnabled.

@Princess-of-Sleeping
Copy link
Contributor

can name them because the same entry exists

// SceSysrootForKernel
//455: ksceSysrootUseInternalStorage 0x50fe3b4d @OFF: 0x2101d VADDR: 0x8102101d
//456: ksceSysrootUseExternalStorage 0x55392965 @OFF: 0x20fc9 VADDR: 0x81020fc9

//742: SceSysrootForDriver_50FE3B4D 0x50fe3b4d @OFF: 0x2101d VADDR: 0x8102101d
//746: SceSysrootForDriver_55392965 0x55392965 @OFF: 0x20fc9 VADDR: 0x81020fc9

@d3m3vilurr
Copy link
Contributor Author

replaced #495

@d3m3vilurr d3m3vilurr closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d3m3vilurr @Princess-of-Sleeping