-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial revert PR410 #415
Partial revert PR410 #415
Conversation
move to SceAppMgr from SceDriverUser
move to SceFios2 from SceDriverUser
@devnoname120 if you want to revert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Looks like some
ksce
prefixes are missing, for example: https://github.com/d3m3vilurr/vita-headers/compare/recheck-sort..partial-revert-410#diff-db62ffcced04f71944400ad9ae4310ceR1627 -
I'm fine with the changes to
SceKernelThreadMgr
because I don't see them used publicly anywhere.
Looks good to me otherwise!
because these nids aren't kernel functions. @Princess-of-Sleeping would be right. |
Are you sure that they are not kernel? Edit: Yeah, the lookup is probably incorrect here. |
well, I saw https://wiki.henkaku.xyz/vita/SceDriverUser#SceErrorUser and https://wiki.henkaku.xyz/vita/SceDriverUser#SceDrmBridgeUser and might be your gist file would be wrong. for example |
I think my lookup is incorrect. Iirc I used some heuristics to determine whether it's kernel or not because the underlying tool that I used didn't provide this information. |
after merge it, we have broken changes that some NID moves to
SceDriverUser
this patch revert this changes.
and we need to check what fields & group moves.
please show this link.
https://github.com/d3m3vilurr/vita-headers/compare/recheck-sort..partial-revert-410
it compare before #410 + apply sort and after this patch.