Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert PR410 #415

Merged
merged 3 commits into from
Aug 4, 2019
Merged

Conversation

d3m3vilurr
Copy link
Contributor

after merge it, we have broken changes that some NID moves to SceDriverUser
this patch revert this changes.
and we need to check what fields & group moves.

please show this link.
https://github.com/d3m3vilurr/vita-headers/compare/recheck-sort..partial-revert-410
it compare before #410 + apply sort and after this patch.

@d3m3vilurr d3m3vilurr requested a review from devnoname120 August 4, 2019 18:35
@d3m3vilurr
Copy link
Contributor Author

@devnoname120 if you want to revert SceKernelThreadMgr part, please tell me :)

Copy link
Member

@devnoname120 devnoname120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Looks like some ksce prefixes are missing, for example: https://github.com/d3m3vilurr/vita-headers/compare/recheck-sort..partial-revert-410#diff-db62ffcced04f71944400ad9ae4310ceR1627

  2. I'm fine with the changes to SceKernelThreadMgr because I don't see them used publicly anywhere.

Looks good to me otherwise!

@d3m3vilurr
Copy link
Contributor Author

because these nids aren't kernel functions. @Princess-of-Sleeping would be right.

@devnoname120
Copy link
Member

devnoname120 commented Aug 4, 2019

Are you sure that they are not kernel?
https://gist.github.com/devnoname120/2975ef91ed5180fe8cf680424ebbde66#file-db_lookup-yml-L8027-L8035

Edit: Yeah, the lookup is probably incorrect here.

@d3m3vilurr
Copy link
Contributor Author

well, I saw https://wiki.henkaku.xyz/vita/SceDriverUser#SceErrorUser and https://wiki.henkaku.xyz/vita/SceDriverUser#SceDrmBridgeUser

and might be your gist file would be wrong. for example SceRtcUser marked kernel: true. are you sure it? our yaml has it with kernel: false :)

@devnoname120
Copy link
Member

I think my lookup is incorrect. Iirc I used some heuristics to determine whether it's kernel or not because the underlying tool that I used didn't provide this information.

@devnoname120 devnoname120 merged commit 4d4144e into vitasdk:master Aug 4, 2019
@d3m3vilurr d3m3vilurr mentioned this pull request Aug 5, 2019
@d3m3vilurr d3m3vilurr deleted the partial-revert-410 branch February 8, 2020 20:30
@d3m3vilurr d3m3vilurr restored the partial-revert-410 branch February 8, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants