Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly resolve hmr dep ids and fallback to url #18840
base: main
Are you sure you want to change the base?
fix: correctly resolve hmr dep ids and fallback to url #18840
Changes from 7 commits
d0b571b
0ba0ae5
cc1bf21
be05e5b
12d66f1
b81e140
ff09f8b
d5d7b94
7a83dfe
d17d16f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sapphi-red I changed this to use
normalizeUrl
which already does the resolve and also calls_ensureEntryFromUrl
.I had to move
_ensureEntryFromUrl
out ofif (environment.config.consumer === 'client') {
check so its also called in ssr