Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP, DO NOT MERGE) Replay drag n drop #286

Merged
merged 25 commits into from
Sep 19, 2020
Merged

(WIP, DO NOT MERGE) Replay drag n drop #286

merged 25 commits into from
Sep 19, 2020

Conversation

vittorioromeo
Copy link
Owner

Major features:

  • Automatically save local best replays to ./Replays
  • Drag and drop a replay file on the SSVOpenHexagon.exe executable to immediately view it

Currently not working properly, for some reason:

  • When playing Arcadia, any saved replay will work correctly after exiting Open Hexagon and dropping the newly saved replay on it
  • When playing other levels, such as Pointless, the replay will be incorrect on the first execution (right after dropping it on the executable), but pressing Y to execute it again will play it correctly
  • There must be some issue with either the RNG seed or with the state of the level that is only fixed after the replay is executed one more time, but I couldn't figure it out yet... help appreciated

@Morxemplum
Copy link
Collaborator

Should label this as a draft if you do not want it to be merged

@vittorioromeo
Copy link
Owner Author

@Morxemplum: done. Let me know if you're willing to spend some time debugging the issue, I can walk you through it

@Morxemplum
Copy link
Collaborator

Morxemplum commented Sep 11, 2020 •
edited
Loading

Lol that's not what I meant by making it a draft. You can convert a pull request to a draft to show it's WIP and you shouldn't merge it. But after a Sound Update PR I'd like to try and take a look at it, but I can't guarantee a solution

Look at #264 for an example

@vittorioromeo vittorioromeo marked this pull request as draft September 11, 2020 11:40
@vittorioromeo
Copy link
Owner Author

Oh I see, lol.

Morxemplum
Morxemplum reviewed Sep 11, 2020
View reviewed changes
src/SSVOpenHexagon/Core/main.cpp
Comment on lines +69 to +71
return "Open Hexagon " + std::string{hg::Config::getVersionString()} +
" - by vittorio romeo - http://vittorioromeo.info";
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad noises

@Morxemplum Morxemplum linked an issue Sep 14, 2020 that may be closed by this pull request
Custom Wall Creation has Memory Leaks #270
Closed
@vittorioromeo vittorioromeo marked this pull request as ready for review September 19, 2020 15:25
@vittorioromeo vittorioromeo merged commit e2cdd38 into master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morxemplum Morxemplum Morxemplum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Wall Creation has Memory Leaks
2 participants
@vittorioromeo @Morxemplum