Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix warnings #357

wants to merge 4 commits into from

Conversation

gportay
Copy link
Contributor

@gportay gportay commented Jan 3, 2019

This fixes warnings reported by make CFLAGS+=-Wall -Wextra

gportay added 4 commits August 5, 2019 15:53
This fixes 2 comparisons between different signedness integers.

The first one is the signal type defined in block structure. In C,
signal numbers are defined as int. This commit fixes the definition in
block.h.

The second one is a comparison between and int and an enum. The
comparison requires the enum to be caseted in int.

The third one is the comparison between the result of snprintf()(ie.
int) and a sizeof variable (ie. size_t). This comparison requires the
int to be casted in unsigned, since the if statement ensures that the
value is not negative. This commit casts the int variable in size_t when
it is compared to a size_t.
The variable err is unused in functions block_send and block_setup.
This fixes several unused parameters using the common method:

	(void)the_unused_parameter;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant