Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog amko 1.12.1 release #242

Open
wants to merge 1 commit into
base: release-1.12.1
Choose a base branch
from
Open

Conversation

arihantg
Copy link
Contributor

@arihantg arihantg commented May 7, 2024

No description provided.

@Dhivyaaj
Copy link

Dhivyaaj commented May 7, 2024

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@arihantg
Copy link
Contributor Author

arihantg commented May 7, 2024

skip jira-id-check

CHANGELOG.md Outdated
## AMKO-1.12.1

### Added:
- AMKO now claims support for Kubernetes 1.28,1.29 and OCP 4.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra space between 1.29 and words

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: there should be space between , 1.29

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken care

CHANGELOG.md Outdated
- PKI Profile used in GSLB Site Persistence can be added via `GlobalDeploymentPolicy` and `GSLBHostRule`

### Bugs fixed
- Fixed an issue of AMKO not able to create GSLB Service for passthrough route as pool member.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these issues reported by customer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was reported by systest not by customer. shall i remove?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we only mention the customer issues here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the bugs section

@Dhivyaaj
Copy link

Dhivyaaj commented May 9, 2024

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@Dhivyaaj
Copy link

Dhivyaaj commented May 9, 2024

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@arihantg
Copy link
Contributor Author

arihantg commented May 9, 2024

skip jira-id-check

@arihantg arihantg requested a review from akshayhavile May 20, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants