Merge pull request #27 from yarmenti/add_nb_name_and_toolbar

Adding Notebook name to html title and in title-toolbar relates to #25
voila-dashboards · Dec 13, 2019 · bbc82a3 · bbc82a3
2 parents ae1aa46 + 34547d6
commit bbc82a3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/share/jupyter/voila/templates/vuetify-base/nbconvert_templates/app.html b/share/jupyter/voila/templates/vuetify-base/nbconvert_templates/app.html
@@ -42,7 +42,8 @@ <h1>{{ loading_text }}</h1>
         return {
             loading_text: "Loading page",
             loadingPercentage: -1,
-            loading: true
+            loading: true,
+            title: ""
         }
     }
 });

diff --git a/share/jupyter/voila/templates/vuetify-base/nbconvert_templates/voila.tpl b/share/jupyter/voila/templates/vuetify-base/nbconvert_templates/voila.tpl
@@ -10,6 +10,9 @@
         <link href='{{resources.base_url}}voila/static/theme-light.css' rel="stylesheet">
         <script src="{{resources.base_url}}voila/static/require.min.js" integrity="sha256-Ae2Vz/4ePdIu6ZyI/5ZGsYnb+m0JlOmKPjt6XZ9JJkA=" crossorigin="anonymous"></script>
         <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no, minimal-ui">
+
+        {% set nb_title = nb.metadata.get('title', '') or resources['metadata']['name'] %}
+		<title>Voila: {{nb_title}}</title>
     </head>
 
     <body data-base-url="{{resources.base_url}}voila/">
@@ -19,22 +22,24 @@
 
         {% include "app.html" %}
     </body>
-{%- set kernel_id = kernel_start() -%}
+	{%- set kernel_id = kernel_start() -%}
     <script id="jupyter-config-data" type="application/json">
         {
           "baseUrl": "{{resources.base_url}}",
           "kernelId": "{{kernel_id}}"
         }
     </script>
     {% set cell_count = nb.cells|length %}
+
     <script>
-    var voila_process = function(cell_index, cell_count) {
-        const loading_text = `Executing cell ${cell_index} of ${cell_count}`
-        console.log(loading_text)
-        app.loading_text = loading_text
-        app.loadingPercentage = cell_index / cell_count * 100
-    }
-
+	   	app.title = "{{nb_title}}"
+	    
+	    var voila_process = function(cell_index, cell_count) {
+	        const loading_text = `Executing cell ${cell_index} of ${cell_count}`
+	        console.log(loading_text)
+	        app.loading_text = loading_text
+	        app.loadingPercentage = cell_index / cell_count * 100
+	    }
     </script>
     {% for cell in cell_generator(nb, kernel_id) %}
         <script>