Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mathjax-extension to render latex in markdown cells #1410

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Use mathjax-extension to render latex in markdown cells #1410

merged 5 commits into from
Oct 31, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Oct 27, 2023 •
edited
Loading

References

  • Voila uses MathJax 3 by default and will switch to MathJax 2 if Voila.mathjax_url or Voila.mathjax_config is provided.
  • Add deprecation warning to Voila.mathjax_url and Voila.mathjax_config

Code changes

  • Remove the Mathjax loading block in the extension
  • Use @jupyterlab/mathjax2-extension or @jupyterlab/mathjax-extension to render latex

User-facing changes

N/A

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/voila/matjax3

@trungleduc trungleduc added the enhancement New feature or request label Oct 27, 2023
@trungleduc trungleduc marked this pull request as draft October 27, 2023 08:52
@trungleduc
Copy link
Member Author

Testing only Mathjax2 due to the issue with MathJax3 in ipywidgets jupyter-widgets/ipywidgets#3829

@trungleduc trungleduc mentioned this pull request Oct 30, 2023
Open
@trungleduc trungleduc marked this pull request as ready for review October 31, 2023 08:25
@trungleduc trungleduc requested a review from jtpio October 31, 2023 08:25
@trungleduc
Copy link
Member Author

Merging by myself to unblock Voici release.

@trungleduc trungleduc merged commit 560dbc1 into voila-dashboards:main Oct 31, 2023
23 checks passed
@trungleduc trungleduc deleted the matjax3 branch February 2, 2024 09:30
@akielbowicz akielbowicz mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio Awaiting requested review from jtpio

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trungleduc