Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mathjax default url and bump ipywidgets packages #1496

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Fix mathjax default url and bump ipywidgets packages #1496

merged 6 commits into from
Oct 9, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Oct 9, 2024 •
edited
Loading

Fix #1486
Fix #688
Fix #568

@martinRenou martinRenou added the bug Something isn't working label Oct 9, 2024
@martinRenou martinRenou requested a review from trungleduc October 9, 2024 16:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Binder 👈 Launch a Binder on branch martinRenou/voila/fix_mathjax_url

@martinRenou
Copy link
Member Author

Fixing CI in #1497

@martinRenou
Copy link
Member Author

Thanks for the review Trung! The last remaining visual regression failure is legit, I'm looking into it

@martinRenou martinRenou merged commit f1722f4 into voila-dashboards:main Oct 9, 2024
22 of 26 checks passed
@martinRenou martinRenou deleted the fix_mathjax_url branch October 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@martinRenou @trungleduc