Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/leaky splits #203
Feature/leaky splits #203
Changes from 8 commits
c8207ce
d8c85e2
0a5412b
d4d2b99
07d06a7
a2b9594
d13a494
d87d769
e42aaf5
110a1c0
8f630bb
6b4eaec
4733226
276489b
a923c6a
80fe828
855c9ac
f6a6652
fe28ce7
7d4a552
d55c9c7
09b5e51
7449545
2d86e79
5b56182
a607ff5
7c741ee
12b0975
a390118
41190c4
fe89ea7
ee20404
07d5bd3
2a63a37
a5ad99c
24b3a29
f53022c
4047459
3b54720
644b8d5
eb34ca0
3e3ddb8
d2bdbd6
13364f7
080e8d7
54ecb5a
ff08fd3
a666b58
e1a7b4f
a352898
1cf9b5f
c445865
9a189e0
49059c9
992767e
27be7fa
4f6f4a0
7d9e418
a12c349
9c51d46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think image hashing is a generally useful enough function that it should be pulled out. For example, the
compute_exact_duplicates
method uses this hash but could also easily be changed to use a image hash.