Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy oracle data #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bastelfreak
Copy link
Member

Result of a discussion we had in #321

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 0.73%. Comparing base (be3c798) to head (cf1cc5d).
Report is 19 commits behind head on master.

❗ Current head cf1cc5d differs from pull request most recent head eb808c4. Consider uploading reports for the commit eb808c4 to get more accurate results

Files Patch % Lines
lib/beaker-hostgenerator/data.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #322      +/-   ##
=========================================
+ Coverage    0.71%   0.73%   +0.01%     
=========================================
  Files          15      15              
  Lines        1811    1764      -47     
=========================================
  Hits           13      13              
+ Misses       1798    1751      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekohl
Copy link
Member

ekohl commented Aug 4, 2023

Perhaps Puppet folks can weigh in here.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually like to continue using oracle. Writing out oraclelinux is tedious. We didn't change centos to centoslinux and also don't write centosstream.

In puppet_metadata we can make sure to generate the right name.

@bastelfreak
Copy link
Member Author

I cleaned it up for the future. I think that's legacy code that could be removed with the next major release.

@bastelfreak bastelfreak force-pushed the oracle branch 2 times, most recently from 5878994 to d94ccf0 Compare August 11, 2023 12:56
@bastelfreak bastelfreak force-pushed the oracle branch 2 times, most recently from c2e8039 to b093fc6 Compare May 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants