Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add dynamic root nodes and interpolation #1

Merged
merged 15 commits into from
Nov 28, 2023

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented Nov 24, 2023

Handled errors in some use cases.
Added unit test about dynamic root nodes and interpolation

<template>
  <button @click="handleClick" :id="count">
   {{count}}
  </button>
</template>
<template>
  <button @click="handleClick" :id="count">
    foo {{count}}
  </button>
</template>
<template>
  <button @click="handleClick" :id="count">
    foo {{count}} foo
  </button>
</template>

# Conflicts:
#	packages/compiler-vapor/__tests__/__snapshots__/basic.test.ts.snap
#	packages/compiler-vapor/src/generate.ts
#	packages/compiler-vapor/src/ir.ts
#	packages/compiler-vapor/src/transform.ts
@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

Copy link

github-actions bot commented Nov 24, 2023

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 58.3 kB 21.9 kB 19.7 kB
compiler-vapor.global.prod.js 18.3 kB 7.26 kB 6.6 kB
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.4 kB 19.7 kB 18 kB
overall 61.4 kB 23.7 kB 21.6 kB
vapor 4.95 kB 2.18 kB 1.95 kB

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem is solved via 91e7f9b

But the unit tested is still needed

packages/compiler-vapor/__tests__/basic.test.ts Outdated Show resolved Hide resolved
@baiwusanyu-c baiwusanyu-c changed the title fix: Fixed rendering error when the root node contains dynamic content chore: added unit test about dynamic root nodes and interpolation Nov 27, 2023
@baiwusanyu-c baiwusanyu-c requested a review from sxzz November 27, 2023 02:52
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty file packages/compiler-vapor/__tests__/__snapshots__/basic.test.ts.snap

packages/compiler-vapor/__tests__/compile.test.ts Outdated Show resolved Hide resolved
baiwusanyu-c and others added 3 commits November 28, 2023 08:58
# Conflicts:
#	packages/compiler-vapor/__tests__/__snapshots__/compile.test.ts.snap
@sxzz sxzz changed the title chore: added unit test about dynamic root nodes and interpolation test: add dynamic root nodes and interpolation Nov 28, 2023
@sxzz sxzz merged commit c1ddb70 into vuejs:main Nov 28, 2023
4 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/rootNode branch November 28, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants