Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vapor errors of v-bind / v-on #3

Merged
merged 13 commits into from
Nov 28, 2023
Merged

feat: add vapor errors of v-bind / v-on #3

merged 13 commits into from
Nov 28, 2023

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Nov 26, 2023 •
edited
Loading

Moved errors.ts from compiler-core to compiler-vapor and conducted unit tests in the v-bind / v-on scenario.

@LittleSound LittleSound changed the title feat: add vapor errors of vBind (WIP) feat: add vapor errors of vBind Nov 26, 2023
@LittleSound LittleSound changed the title feat: add vapor errors of vBind feat: add vapor errors of v-bind / v-on Nov 26, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 58.4 kB (+37 B) 22 kB (+15 B) 19.7 kB (+34 B)
compiler-vapor.global.prod.js 18.5 kB (+211 B) 7.34 kB (+80 B) 6.67 kB (+68 B)
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.4 kB 19.7 kB 18 kB
overall 61.4 kB 23.7 kB 21.6 kB
vapor 4.95 kB 2.18 kB 1.95 kB

sxzz
sxzz reviewed Nov 27, 2023
View reviewed changes
packages/compiler-vapor/src/errors.ts Outdated Show resolved Hide resolved
packages/compiler-vapor/src/transform.ts Show resolved Hide resolved
packages/compiler-vapor/src/transform.ts Outdated Show resolved Hide resolved
packages/compiler-vapor/src/transform.ts Outdated Show resolved Hide resolved
packages/compiler-vapor/src/errors.ts Outdated Show resolved Hide resolved
packages/compiler-vapor/src/errors.ts Outdated Show resolved Hide resolved
sxzz
sxzz approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the rest part. Thanks!

packages/compiler-core/src/errors.ts Outdated Show resolved Hide resolved
@sxzz sxzz merged commit 4200d4e into vuejs:main Nov 28, 2023
4 checks passed
@LittleSound LittleSound deleted the feat/add-vapor-errors branch November 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LittleSound @sxzz