Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rebuild theme-default #134

Open
wants to merge 100 commits into
base: main
Choose a base branch
from
Open

feat: rebuild theme-default #134

wants to merge 100 commits into from

Conversation

Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9125046679

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.759%
Totals Coverage Status
Change from base Build 9123655949: 0.0%
Covered Lines: 681
Relevant Lines: 1238
💛 - Coveralls

Mister-Hope
Mister-Hope commented May 29, 2024
View reviewed changes
themes/theme-next/src/client/components/VPSidebarItem.vue Show resolved Hide resolved
themes/theme-next/package.json Outdated Show resolved Hide resolved
themes/theme-next/src/node/markdown/githubAlertsPlugin.ts Outdated Show resolved Hide resolved
themes/theme-next/package.json Outdated Show resolved Hide resolved
@pengzhanbo
Copy link
Member

@Mister-Hope @meteorlxy

The new default theme is ready !

However, there seems to be a problem with the e2e tests; during the document build phase, it got stuck, and I couldn't find the source of the issue. Please help investigate and resolve it.

Mister-Hope
Mister-Hope commented Nov 28, 2024
View reviewed changes
themes/theme-next/src/node/config/templateBuildRenderer.ts
@@ -0,0 +1,37 @@
import type { TemplateRendererContext } from 'vuepress/utils'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file could be extracted to @vuepress/theme-helper

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @vuepress/theme-helper can be included in future update plans.

Copy link
Member Author

@Mister-Hope Mister-Hope Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of functions can be extracted to @vuepress/theme-helper, I think we can start this migration in this pr, and cherry pick the changes to main continuously.

This can avoid a huge change being merged with a single commit.

@Mister-Hope
Copy link
Member Author

@pengzhanbo Can you send a pr about onContentUpdate to the core repo?

@pengzhanbo
Copy link
Member

@pengzhanbo Can you send a pr about onContentUpdate to the core repo?

Done. vuepress/core#1620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorlxy meteorlxy meteorlxy left review comments

@pengzhanbo pengzhanbo pengzhanbo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mister-Hope @coveralls @pengzhanbo @meteorlxy