-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init flexsearch plugin #91
base: main
Are you sure you want to change the base?
Conversation
7e2f3bf
to
880ecc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes are required
also please add en docs, I can complete the zh one |
thanks for the review, I'll try to address when I have a chance later! |
0cc1529
to
6ad2695
Compare
hi, I think I've addressed your comments :) I've based the docs from the search plugin (as the whole plugin :) ), and adapted a bit. |
Pull Request Test Coverage Report for Build 8458428701Details
💛 - Coveralls |
plugins/plugin-flexsearch/src/client/composables/useSearchSuggestions.ts
Outdated
Show resolved
Hide resolved
33f9b55
to
aa9f0b2
Compare
updated again :) |
aa9f0b2
to
f462b7f
Compare
1d9072f
to
e2ad70f
Compare
hi, comments (I think) have been addressed, also upgraded flexsearch to 0.7, please can you review again? thanks |
It would be great if you can ensure to make new commits instead of rebase and force push. That makes us hard to review. Here are some suggestions:
The original search plugin only index headings, so we do not need to consider these things, however a enhanced seach plugin could achieve these, and even more like search history, better text extracting and others. An example could be search-pro |
plugins/plugin-flexsearch/src/client/composables/findInIndex.ts
Outdated
Show resolved
Hide resolved
} | ||
` | ||
|
||
const prepContent = (html: string): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is too simple IMO, perhaps you can have a look at search-pro plugin.
Understood
All these are great ideas, however, I don't think I have time enough to implement them :) All I wanted is to publish the plugin that I had to maintain separately so I don't need to upgrade it manually every time I upgrade vuepress, but for these changes we'd need to find a proper maintainer of the plugin. As I see the options are:
Thanks |
Don't worry , I can finish these, but will take time. I am planning to migrate search-pro plugin to this repo first. |
thank you! also given this, I'm happy if I'm removed from the author field - given I've only copied and adapted, and you're about to improve it in a serious way :) all the best! and thanks again for maintaining this project! |
Hi, sorry for the long delay. We already release a package called Flexsearch does have higher performance in its brenchmark so I am still pretty interested in this PR. |
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Adds flexsearch plugin