Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for braintree payments #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mdavo6
Copy link
Contributor

@mdavo6 mdavo6 commented Sep 1, 2022

Add support for Braintree payments drop in UI - requires spree_braintree_vzero gem.

Notes:

  1. API-client is currently failing as braintree_nonce is not currently a supported type in spree-storefront-api-v2-js-sdk. I have submitted a PR to address this: Add braintree nonce to IPayment to support spree_braintree_vzero spree/spree-api-v2-js-sdk#346
  2. Requires the new Braintree token generation API endpoint provided in the following PR: Add new API v2 endpoint to support Braintree Token generation spree-contrib/spree_braintree_vzero#272

Description

  • Added new getBraintreeToken API call.
  • Added braintree nonce to payment attributes (as required by spree_braintree_vzero gem).
  • Added braintreetoken type.
  • Added new braintree.vue payment method component.
  • Added braintree-web-drop-in as new dependency (required by braintree.vue payment method component).

Related Issue

#260

Motivation and Context

Braintree is a popular payment gateway in the Spree community. Supporting Braintree out of the box will offer merchants greater options, including offering Paypal as a payment method.

How Has This Been Tested?

Tested on chrome.

Screenshots (if appropriate):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation. (Will need to update readme document if approved).
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@rafalcymerys rafalcymerys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdavo6 thanks, this looks solid! @letelete would you like to take a look as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants