-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support SVGPath #243
base: main
Are you sure you want to change the base?
Conversation
hi @BobbieGoede can you pre-review this, and give me some advice? |
commit: |
Sorry again for the delays in reviewing this PR is a bit more involved and I'm contributing on several projects at the same timeπ My initial thoughts:
Please let me know if more clarification is needed π Contributions are always appreciated, just making sure we preserve maintainability when adding more functionality πͺ |
thanks a lot π i saw the code now i use export interface SVGPathProperties {
pathLength?: number
pathOffset?: number
pathSpacing?: number
} but like |
π Linked issue
#241
β Type of change
π Description
SVGPath related properties are not processed originally
MotionProperties
is defined includesSVGPathProperties
, but does not processstyle
supports processpathLength
,pathSpacing
,pathOffset
pathLength
always normalize to 1pathLength
andpathSpacing
tostroke-dasharray
.stroke-dasharray = pathLength pathSpacing
4.1
stroke-dasharray = pathLength pathSpacing
. this support process dashes and gaps are two or same size, can't process that dashes and gaps of various sizes with an odd number of values, like4,1,2
which is equivalent to[4,1,2,4,1,2]
pathOffset
tostroke-dashoffset
π Checklist